Deprecated support for django-polymorphic resources #1303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desired for Django Polymorphic support to be added in an external 3rd party library in case there is a demand and someone is to be found who will take the lead.
|
@n2ygk Please let me know what you think about this deprecation strategy before you merge, whether you think that is a good way forward or have any other suggestions? Thanks. |
|
It seems like a very lightly used feature if at all and pretty impactful in terms of added DJA support complexity. It's not even clear from #1087 (comment) whether @Elawphant is still relying on it (past tense use of "was"). The deprecation warnings are certainly the best way to get anyone's attention to determine the potential impact. I'm OK with merging this as is. Let me know if you want me to go ahead. |
|
Good that we are on the same page. Let's go ahead and merge it then. |
n2ygk
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
I have started discussion #1194 almost two years ago in terms of Django Polymorphic support in DJA and what it is used for. I have pinged people in the different PRs and issues about Polymorphic. The only response I got is at #1087 (comment), but otherwise no feedback.
My feeling is that either Django Polymorphic support in DJA is not really used or people are not aware of the surrounding discussion.
The goal of deprecation is that users who use it will become aware of the discussion, and we get a group of people who hopefully will be able to work on Django Polymorphic support in an external library.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS